Dismissing Reviews & Restrictions

[BenjamenMeyer]

Select Topic Area

Question

Body

Question: how do rules, branch protections, and restricting who can dismiss a review interact?

Background:
One set of repositories I operate in have the Restrict Who Can Dismiss a Review setting set in the branch protections. The problem I am running into is with the following workflow:

• I review a PR and request changes
• My changes get addressed
• I want to dismiss my own review to unblock the PR but I do not want to approve the PR.

At present, I cannot dismiss my review (request for changes) without approving it, thereby allowing it to be merged which I explicitly do not want to do. My present work around is to wait for others to approve it and then approve it when it's clearly going to be allowed.

NOTE: I've seen changes happen that do not auto-dismiss my review; probably because it's not detected as stale so the option to Dismiss stale reviews which is already selected is not a completely solution.

Final Question: Is this expected behavior? Or are there potentially other organization level rules that are effecting this?

I'd like to be able to have an intelligent conversation to fix the workflow as I'd expect to be able to dismiss my own reviews only when that option is selected so any insights would be greatly appreciated.

Related URLS:

• https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/dismissing-a-pull-request-review
• https://github.blog/2016-10-12-dismissing-reviews-on-pull-requests/
• https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-rulesets/managing-rulesets-for-a-repository

None cover how these interact, and the documentation on Branch Protections just points to the the documentation on Dismissing Reviews for more information; yet no information about how user permissions or what exactly the restriction means or is applied is actually discussed.

NOTE: Not sure if this should be part of Pull Requests or Repositories discussions both make sense.

[jcook-uptycs]

Another reason a reviewer should always be able to dismiss their own review is if they approved it and realized they no longer what to approve it, but not request changes.

This could be approval in error or in light of new new information.

[github-actions[bot]]

🕒 Discussion Activity Reminder 🕒

This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions:

1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as out of date at the bottom of the page.

2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own.

3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution.

Note: This dormant notification will only apply to Discussions with the Question label. To learn more, see our recent announcement.

Thank you for helping bring this Discussion to a resolution! 💬

[BenjamenMeyer]

NOTE: for GH Bot - this has not had a resolution or any advise provided yet. If I learn of something I'll update this too so others can know too.

[github-actions[bot]]

🕒 Discussion Activity Reminder 🕒

This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions:

1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as out of date at the bottom of the page.

2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own.

3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution.

Note: This dormant notification will only apply to Discussions with the Question label. To learn more, see our recent announcement.

Thank you for helping bring this Discussion to a resolution! 💬

[BenjamenMeyer]

this has been unanswered by GH Staff. Still looking for an answer

[github-actions[bot]]

🕒 Discussion Activity Reminder 🕒

This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions:

1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as out of date at the bottom of the page.

2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own.

3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution.

Note: This dormant notification will only apply to Discussions with the Question label. To learn more, see our recent announcement.

Thank you for helping bring this Discussion to a resolution! 💬

[BenjamenMeyer]

this has been unanswered by GH Staff. Still looking for an answer

[github-actions[bot]]

🕒 Discussion Activity Reminder 🕒

This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions:

1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as out of date at the bottom of the page.

2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own.

3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution.

Note: This dormant notification will only apply to Discussions with the Question label. To learn more, see our recent announcement.

Thank you for helping bring this Discussion to a resolution! 💬

[BenjamenMeyer]

this has been unanswered by GH Staff. Still looking for an answer

[github-actions[bot]]

🕒 Discussion Activity Reminder 🕒

This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions:

1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as out of date at the bottom of the page.

2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own.

3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution.

Note: This dormant notification will only apply to Discussions with the Question label. To learn more, see our recent announcement.

Thank you for helping bring this Discussion to a resolution! 💬