HTTP plugin: serve_http: invalid multiple values to key date in tree

[FluffyDiscord]

No duplicates 🥲.

• I have searched for a similar issue in our bug tracker and didn't find any solutions.

What happened?

HTTP server seems o fail to handle the following payload:

I does make sense as this is user error, but it should not return status code 500 with plaintext message serve_http: invalid multiple values to key 'XXX' in tree, but instead silently skip that invalid key. This error is not logged inside PHP since it wont even reach the PHP runtime.

If this is intended behavior, please add option we can toggle and silently skip this error. I would rather get half of the input that I can validate than nothing at all.

Version (rr --version)

2.12.3

How to reproduce the issue?

payload source, POST FormData

------WebKitFormBoundaryl6lIWCjXEqjruvDz
Content-Disposition: form-data; name="duplicate_daily_record_day[date][date]"

2023-06-16
------WebKitFormBoundaryl6lIWCjXEqjruvDz
Content-Disposition: form-data; name="duplicate_daily_record_day[sectionsToCopy][]"

PERMISSION_TYPE_DAILY_RECORD_ON_SITE_MECHANISM
------WebKitFormBoundaryl6lIWCjXEqjruvDz
Content-Disposition: form-data; name="duplicate_daily_record_day[date]"

2023-06-14 00:00
------WebKitFormBoundaryl6lIWCjXEqjruvDz
Content-Disposition: form-data; name="duplicate_daily_record_day[_token]"

86.ASFz-b72sEhJDViwjmrOEEiYg4FpsOpfGEEA8M-FaZ4.NUgXg8-65gR5WhX9wFi0UyTB9dEj5r9uSXdTwqDJRPB3SRK92L7GPgVdEQ
------WebKitFormBoundaryl6lIWCjXEqjruvDz--

Relevant log output

No response

[rustatian]

Hey @FluffyDiscord 👋🏻
Could you please check the latest stable version? v2023.1.5. I remember that I fixed similar bug.

[rustatian]

I does make sense as this is user error, but it should not return status code 500 with plaintext message serve_http: invalid multiple values to key 'XXX' in tree, but instead silently skip that invalid key.

You may override internal error code to any code you need.

I'm against the practice of silently skipping errors. Since RR cannot parse the payload with errors, errors should be returned explicitly.

Another question is: How to handle duplicates? As far as I remember, according to the RFC 7578 there is no clear answer on that.

[rustatian]

I'm moving this issue to Discussion since this is not a bug, but rather a question that needs to be discussed.

P.S. Please attach a curl/postman request to your issue to clearly reproduce this behavior..