Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support displaying general file information on Windows #35

Open
orhun opened this issue Sep 17, 2024 · 0 comments
Open

Support displaying general file information on Windows #35

orhun opened this issue Sep 17, 2024 · 0 comments
Labels
effort: medium Something that can be done quickly with some effort enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@orhun
Copy link
Owner

orhun commented Sep 17, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

binsider now support Windows (when building via --no-default-features) after #31, however the general file information is not available due to the Rust API differences between Linux.

See the failed workflow for more information: https://github.com/orhun/binsider/actions/runs/10902683795/job/30255132721?pr=31

We need to solve these build errors via refactoring file.rs in a more generic way.

Unfortunately I don't have a development environment for Windows and running the following command again and again on Linux is not very convenient for developing/testing this:

cross build --target x86_64-pc-windows-gnu --no-default-features

Describe the solution you'd like

One idea is to create a trait called PlatformFileInfo (I'm bad at naming) and implement it for FileInfo for having generalized functions for both Linux and Windows. Eventually update ui.rs and other related files to render the file information correctly.

To do this, one should also remove the if cfg!(target_os = "windows") checks. See 83657f9 for more information.

Describe alternatives you've considered

None. I'm open to ideas though!

Additional context

See:

https://doc.rust-lang.org/stable/std/os/linux/fs/trait.MetadataExt.html

vs

https://doc.rust-lang.org/stable/std/os/windows/fs/trait.MetadataExt.html
@orhun orhun added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 17, 2024
orhun added a commit that referenced this issue Sep 17, 2024
@orhun
chore(file): disable general file analysis for windows
83657f9 
#35
@orhun orhun mentioned this issue Sep 18, 2024
Closed
orhun added a commit that referenced this issue Sep 18, 2024
@orhun
feat(dynamic): make dynamic analysis optional for better platform sup…
580c9ec 
…port (#31)

* feat(dynamic): make dynamic analysis optional for better platform support

* feat(ci): expand the build matrix

* chore(file): disable general file analysis for windows

#35

* feat(release): publish pre-built binaries for more platforms

* docs(website): mention feature flags

* chore: enable builds for more platforms

* chore(ci): add powerpc64le-unknown-linux-gnu target
@orhun orhun added the effort: medium Something that can be done quickly with some effort label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: medium Something that can be done quickly with some effort enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orhun