From f53a74b20284c62c9fb3fbd8f7c01f91dd206c21 Mon Sep 17 00:00:00 2001 From: Tom Schlick Date: Tue, 2 Jun 2020 09:50:33 -0400 Subject: [PATCH] remove database transaction that could cause lockups (#16) --- src/ProcessStamp.php | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/ProcessStamp.php b/src/ProcessStamp.php index 4d599f7..1987aa7 100644 --- a/src/ProcessStamp.php +++ b/src/ProcessStamp.php @@ -58,13 +58,11 @@ public static function firstOrCreateByProcess(array $process, ?string $hash = nu $parent = static::firstOrCreateByProcess(static::getProcessName($process['type'], $process['parent_name'])); } - return DB::transaction(function () use ($hash, $process, $parent) { - return static::lockForUpdate()->firstOrCreate(['hash' => $hash], [ - 'name' => trim($process['name']), - 'type' => $process['type'], - 'parent_id' => optional($parent)->getKey(), - ]); - }, 5); + return static::lockForUpdate()->firstOrCreate(['hash' => $hash], [ + 'name' => trim($process['name']), + 'type' => $process['type'], + 'parent_id' => optional($parent)->getKey(), + ]); } /**