You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I was checking the implementation and there is something which looks kind of strange. What is the reason that makes you to override the emit method, isn't it just fine to subscribe on the 'error' event and then do the same thing?
Currently this stops the events so in case that I have some application logic like "redis is unavailable so do x.y.z" can't be implemented.
Thanks
The text was updated successfully, but these errors were encountered:
Yes - the error handling is pretty poor at the moment. The reason we override the emit method is so that we can stop an error propagating upwards when we want to reconnect. Without that every client using the library would have to do some form of decent error handling. What should probably happen is that we check for connection errors specifically and try a reconnect and then if that still fails raise the error.
Hi, I was checking the implementation and there is something which looks kind of strange. What is the reason that makes you to override the emit method, isn't it just fine to subscribe on the 'error' event and then do the same thing?
Currently this stops the events so in case that I have some application logic like "redis is unavailable so do x.y.z" can't be implemented.
Thanks
The text was updated successfully, but these errors were encountered: