Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No padding between icon and text in Upload component when using Oruga Full theme #83

Open
AdityaBhate opened this issue Nov 14, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@AdityaBhate
Copy link

Overview of the problem

Oruga version: v0.9.0
OS/Browser: Chrome 130.0.6723.117 and FireFox 132.0.2 (64-bit)

Description

When using the "Oruga Full" theme, the Upload component has no padding between the upload icon and the "Click to upload" text. This causes the icon and text to appear too close to each other, impacting readability and aesthetics.

image

Steps to reproduce

Set the Oruga theme to "Oruga Full".
Navigate to the Upload component.
Observe the lack of padding between the upload icon and text in the upload button.

Expected behavior

To improve spacing and visual clarity, the upload icon and the "Click to upload" text should be slightly padded.
Actual behavior
Something like this (not exactly)

image

The upload icon and text are displayed without any padding, causing them to appear cramped together, ruining the asthetic

@AdityaBhate
Copy link
Author

I would like to work on this issue if possible

@mlmoravek
Copy link
Member

Hey @AdityaBhate, I appreciate your engagement to contribute :)
First, I would suggest opeaning thinks like this in the repo of the respective theme (https://github.com/oruga-ui/theme-oruga).

Second, it's not a problem with the Upload component, because you can pass any element in the trigger slot. The button here is just an example.
However, we could add some spacing like the bulma theme does

@mlmoravek mlmoravek transferred this issue from oruga-ui/oruga Nov 14, 2024
@mlmoravek mlmoravek added the enhancement New feature or request label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants