Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples use incorrect search param "aal2" instead of "aal" #220

Open
5 tasks done
joekrill opened this issue Oct 4, 2024 · 0 comments
Open
5 tasks done

Examples use incorrect search param "aal2" instead of "aal" #220

joekrill opened this issue Oct 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@joekrill
Copy link

joekrill commented Oct 4, 2024

Preflight checklist

Ory Network Project

No response

Describe the bug

The react-spa and preact-spa examples appear to read the wrong query string parameter when checking if aal2 is requested:

  const aal2 = searchParams.get("aal2")

As far as I can tell the parameter name is "aal", not "aal2", and it will be set to the value "aa2". Either that or the documentation is wrong? The nextjs-spa seems to use the correct parameter:

  const aal = String(router.query.aal || "")

Reproducing the bug

Run the react-spa or preact-spa example in a way that aal2 is requried.

Relevant log output

No response

Relevant configuration

No response

Version

n/a

On which operating system are you observing this issue?

None

In which environment are you deploying?

None

Additional Context

The examples also seem to be missing the @ory/client dependency in their package.json (including the nextjs-spa example)

@joekrill joekrill added the bug Something isn't working label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant