Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow revoking access token without revoking refresh token #748

Open
5 of 6 tasks
apexskier opened this issue May 4, 2023 · 4 comments
Open
5 of 6 tasks

Allow revoking access token without revoking refresh token #748

apexskier opened this issue May 4, 2023 · 4 comments
Labels
feat New feature or request.

Comments

@apexskier
Copy link

apexskier commented May 4, 2023

Preflight checklist

Describe your problem

We'd like to be able to revoke an individual access token without revoking a refresh token.

The spec says:

If the token passed to the request is an access token, the server MAY revoke the respective refresh token as well.

Currently, fosite revokes both access and refresh tokens on any token revocation:

err1 = r.TokenRevocationStorage.RevokeRefreshToken(ctx, requestID)
err2 = r.TokenRevocationStorage.RevokeAccessToken(ctx, requestID)

This effectively means we cannot revoke an access token if using refresh tokens, since it makes the refresh token useless.

Describe your ideal solution

Ideally, we'd like the token revocation endpoint to not revoke refresh tokens when an access token is revoked.

Alternatively, it would work if we could to configure this behavior (either globally for our hydra instance or with an additional parameter to the revocation endpoint).

Workarounds or alternatives

We're not revoking access tokens where we'd like to be right now.

Another alternative would be to expose an admin endpoint in ory/hydra to revoke just access tokens.

Version

oryd/hydra:v2.1.1

Additional Context

No response

@apexskier apexskier added the feat New feature or request. label May 4, 2023
@apexskier
Copy link
Author

We just hit this again in another use case

@vivshankar
Copy link
Contributor

I believe this addresses this issue:

#766

Waiting on a review.

Copy link

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas on how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan for resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Nov 11, 2024
@vivshankar
Copy link
Contributor

Waiting for @aeneasr to review the unit tests and merge.

@github-actions github-actions bot removed the stale Feedback from one or more authors is required to proceed. label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants