Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor parameter parsing in ListIdentities and disallow combining filters #4244

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Dec 12, 2024

The code for ListIdentities has gotten out of hand. The string-based query building is not sustainable. @aeneasr and I feel we have no choice for now but to disable combining filters (like GET /admin/identities?organization_id=abc&credential_identifier=xyz).

This will allow us to build a simple switch into the ListIdentities handler to go to optimized implementations for each filter in the future and in cloud.

@alnr alnr self-assigned this Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.58%. Comparing base (8cbb5bd) to head (de69e47).

Files with missing lines Patch % Lines
identity/handler.go 95.12% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4244      +/-   ##
==========================================
- Coverage   79.10%   78.58%   -0.53%     
==========================================
  Files         381      380       -1     
  Lines       28012    27275     -737     
==========================================
- Hits        22159    21434     -725     
- Misses       4209     4221      +12     
+ Partials     1644     1620      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant