-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add scopes validator for logical evalulation #1143
base: master
Are you sure you want to change the base?
Conversation
092d073
to
9fd1709
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1143 +/- ##
==========================================
- Coverage 78.16% 77.72% -0.45%
==========================================
Files 80 80
Lines 3898 4036 +138
==========================================
+ Hits 3047 3137 +90
- Misses 576 618 +42
- Partials 275 281 +6 ☔ View full report in Codecov by Sentry. |
I couldn't reproduce linter check issues locally. Dockers issues seem to pop up in other PR too. https://github.com/ory/oathkeeper/pull/1138/checks |
This feature introduces logical "OR" in the scope validation. Any match would suffice here. Example below. Details in issue.
Example of a match:
"required_scope": ["scope1", "scope2"]
token scopes: "scope1"
Related issue(s)
#1129
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments
Corresponding docs PR: ory/docs#1608