Consider a generic implementation of Unique() func

[ilmanzo]

with reference to:

openqa-mon/cmd/openqa-mon/util.go

Line 44 in 900c714

func unique(a []int) []int {

and

openqa-mon/cmd/openqa-mon/util.go

Line 56 in 900c714

func unique64(a []int64) []int64 {

a sample implementation with generics types (introduced in Go 1.18) that also avoids allocating a map of bools:

func unique[T comparable](slice []T) []T {
    seen := make(map[T]struct{})
    unique := []T{}

    for _, item := range slice {
        if _, exists := seen[item]; !exists {
            seen[item] = struct{}{}
            unique = append(unique, item)
        }
    }

    return unique
}

to call it:

uniqueInts := unique([]int{1, 2, 2, 3, 4, 4, 5})
uniqueStrings := unique([]string{"apple", "banana", "apple", "cherry"})
uniqueFloat64s := unique([]float64{1.1, 2.2, 2.2, 3.3, 4.4})

[ilmanzo]

Opening this issue only to have your opinion, if you like the idea I will follow up with a Pull Request :)

[grisu48]

This would be a great refactoring idea. I think the code still originates from the pre-generics time, or at least when we used a go version that didn't had generics.

Feel free to open a PR 🙂