Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CORE clock support #1668

Merged
merged 16 commits into from
Aug 2, 2024
Merged

Add CORE clock support #1668

merged 16 commits into from
Aug 2, 2024

Conversation

chungshien-chai
Copy link
Collaborator

@chungshien-chai chungshien-chai commented Aug 1, 2024

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

What does this pull request change?

Which part of the code base require a change

  • Library:
  • Plug-in:
  • Engine
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

This is to support CORE clock determination by ovewrite IO clock out mux.
The original bitstream_setting.xml will be modified before supplying to OpenFPGA
bitstream_setting.xml might have the IO clock out mux information that we would like to set.

Note: Backend with lastest OpenFPGA will need to merged into Raptor first or same time with this PR into Raptor

Testing done:

  • Port OpenFPGA overwrite-bitstream support and this change to latest NS Raptor
  • Run test/batch, test/batch_gen2 and test/batch_gen3

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break back-compatibility. If so, please list who may be influenced.

@chungshien-chai chungshien-chai changed the title Add CORE clock support (Backend Needs to merge into Raptor first or at the same time) Add CORE clock support (Backend thta have latest OpenFPGA Needs to merge into Raptor first or at the same time) Aug 1, 2024
@chungshien-chai chungshien-chai marked this pull request as draft August 1, 2024 20:32
@chungshien-chai chungshien-chai changed the title Add CORE clock support (Backend thta have latest OpenFPGA Needs to merge into Raptor first or at the same time) Add CORE clock support Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 61.01695% with 46 lines in your changes missing coverage. Please review.

Project coverage is 14.73%. Comparing base (4ce7fec) to head (1403f05).

Files Patch % Lines
src/Compiler/CompilerOpenFPGA.cpp 0.00% 25 Missing ⚠️
.../ModelConfig/ModelConfig_BITSTREAM_SETTING_XML.cpp 72.00% 4 Missing and 17 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1668      +/-   ##
==========================================
+ Coverage   14.64%   14.73%   +0.08%     
==========================================
  Files         478      480       +2     
  Lines       63617    63729     +112     
  Branches    25948    26083     +135     
==========================================
+ Hits         9319     9390      +71     
- Misses      53102    53135      +33     
- Partials     1196     1204       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chungshien-chai chungshien-chai marked this pull request as ready for review August 2, 2024 08:14
@alaindargelas alaindargelas merged commit a4ebae0 into main Aug 2, 2024
32 of 33 checks passed
@alaindargelas alaindargelas deleted the foedag-io-utst branch August 2, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants