Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bitstream setting for SOC clock #1714

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Support bitstream setting for SOC clock #1714

merged 3 commits into from
Oct 29, 2024

Conversation

chungshien-chai
Copy link
Collaborator

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

Support new design_edit.sdc command "set_soc_clk" which is to set IO tile bitstream for SOC clocking

What does this pull request change?

Which part of the code base require a change

  • Library:
  • Plug-in:
  • Engine
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break back-compatibility. If so, please list who may be influenced.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 14.75%. Comparing base (b2ad5a5) to head (2fff60a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../ModelConfig/ModelConfig_BITSTREAM_SETTING_XML.cpp 80.95% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1714      +/-   ##
==========================================
+ Coverage   14.46%   14.75%   +0.28%     
==========================================
  Files         478      478              
  Lines       63822    66518    +2696     
  Branches    26143    26089      -54     
==========================================
+ Hits         9230     9812     +582     
- Misses      53346    55449    +2103     
- Partials     1246     1257      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chungshien-chai
Copy link
Collaborator Author

chungshien-chai commented Oct 29, 2024

@NadeemYaseen

My code does not involve any QT changes, but msys2 fail with QT related error

Do you have any idea?

image

@NadeemYaseen
Copy link
Contributor

@NadeemYaseen

My code does not involve any QT changes, but msys2 fail with QT related error

Do you have any idea?

image

@ravikiranchollangi The version of Qt base installed via mingw on Windows has changed from 6.7.2-2 to 6.8.0-2. Due to this, we are seeing the error of depreciation, as shown in the CS comment screenshot. Is it possible to update our code to make it compatible with the latest version before I try to hard code the Qt base version?

@ravikiranchollangi
Copy link
Contributor

We will fix the Qt stuff in later PR, merging this in.

@ravikiranchollangi ravikiranchollangi merged commit 52f827e into main Oct 29, 2024
33 of 35 checks passed
@ravikiranchollangi ravikiranchollangi deleted the foedag-soc branch October 29, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants