Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the underscore from the no_shipping module name and code. #141

Open
JasperVeerman opened this issue Dec 14, 2024 · 0 comments
Open

Comments

@JasperVeerman
Copy link

Please remove the underscore from the no_shipping module name, class name and class->code property.

The underscore in the no_shipping class code property breaks the shipping estimate ajax functionality on the frontend.

On frontend shopping cart estimate ajax postback, the value no_shipping_no_shipping will be incorrectly parsed into ($module, $class) array bij the OrderManager.setSelectedShipping() function (lib\common\services\OrderManager.php). As a result the no_shipping selection gets lost and the default shipping method is selected.

    public function setSelectedShipping($shipping) {
        if ($this->isShippingNeeded() && (strpos($shipping, '_') !== false)) {
            list($module, $method) = explode('_', $shipping);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant