Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-installation Check does not check for php-gmp #61

Open
divinity76 opened this issue Jan 14, 2024 · 1 comment
Open

Pre-installation Check does not check for php-gmp #61

divinity76 opened this issue Jan 14, 2024 · 1 comment

Comments

@divinity76
Copy link

the bundled composer library minishlink/web-push v5.2 requires php-gmp, see line 23 here https://github.com/web-push-libs/web-push-php/blob/v5.2.5/composer.json#L23
but the Pre-installation Check does not check for php-gmp

@divinity76
Copy link
Author

divinity76 commented Jan 14, 2024

notably if we update to minishlink/web-push >=v6, gmp is no longer required: https://github.com/web-push-libs/web-push-php/blob/v6.0.7/composer.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant