2.4 - newsletter bug with EMAIL_FROM

[oitsuki]

Hello harald,

On 2.4, when you try to send a newsletter, there is a problem.
EMAIL_FROM has a problem (configuration / email from)when you try to send a newsletter,

the EMAIL_FROM in db configuration is writen like this :
configuration of EMAIL_FROM : admin admin@admin, toto [email protected]

EMAIL_FROM in newsletter is writen like this :
/home/www/test/oscommerce2/catalog/admin/newsletters.php:19: string(45) ""admin" , 'toto' "
In this case, it's impossible to send a newsletter, an error appear.

if you write EMAIL_FROM : admin@admin ==> newsletter work
if you write EMAIL_FROM : admin@admin, [email protected] ==> newsletter does'nt work
if you write EMAIL_FROM : admin@admin, [email protected] ==> newsletter does'nt work
if you write EMAIL_FROM : admin admin@admin ==> newsletter does'nt work
if you write EMAIL_FROM : admin admin@admin, toto [email protected] ==> newsletter does'nt work

server :7.0.8-0ubuntu0.16.04.2 (Zend : 3.0.0)
MySQL 5.7.13-0ubuntu0.16.04.2

[oitsuki]

htmlentities(EMAIL_FROM) seems to be the solution
idem for SEND_EXTRA_ORDER_EMAILS_TO : htmlentities(SEND_EXTRA_ORDER_EMAILS_TO)

[haraldpdl]

The email from field should only contain one email address, either with a name or without. Multiple from addresses are not supported properly (this hasn't been tested or looked into).

The format is pretty strict so EMAIL_FROM should be split into EMAIL_FROM_NAME (which can be empty) and EMAIL_FROM_ADDRESS (which is required). The email class can then properly set the from value.