tep_round() does not work with negative numbers

[tgely]

https://github.com/osCommerce/oscommerce2/blob/master/catalog/includes/functions/general.php#L297-L315

There are not interpreted negative numbers in tep_round() function. I dont see where are conflicts with negative currencies so I dont understand the reason.

Here is a quick fix with abs number:

  function tep_round($number, $precision) {
    if ($number < 0) {
      $sign = -1;
    } else {
      $sign = 1;
    }

    $number = abs($number);
    if (strpos($number, '.') && (strlen(substr($number, strpos($number, '.')+1)) > $precision)) {
      $number = substr($number, 0, strpos($number, '.') + 1 + $precision + 1);
      if (substr($number, -1) >= 5) {
        if ($precision > 1) {
          $number = substr($number, 0, -1) + ('0.' . str_repeat(0, $precision-1) . '1');
        } elseif ($precision == 1) {
          $number = substr($number, 0, -1) + 0.1;
        } else {
          $number = substr($number, 0, -1) + 1;
        }
      } else {
        $number = substr($number, 0, -1);
      }
    }

    return $sign * $number;
  }

[Gergely]

@haraldpdl

could be deprecated the tep_round()? There is no php3 compatibility and no negative number functionality at all.

[Gergely]

master...Gergely:issue_406