Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxes not applying to taxable goods at checkout #520

Open
scottcwilson opened this issue Nov 17, 2016 · 3 comments
Open

Taxes not applying to taxable goods at checkout #520

scottcwilson opened this issue Nov 17, 2016 · 3 comments
Assignees

Comments

@scottcwilson
Copy link
Contributor

Configuration is Display Prices with Tax = false, checking out with account in a zone subject to tax. Fresh install of current Github master.

@haraldpdl
Copy link
Contributor

The tax is shown in the order total listing however not besides the products.

Line 146; if the if (sizeof($order->info['tax_groups']) > 1) statement is removed, the tax is shown however it shows 0% for products where tax is not applicable. Will be looked into further.

Assigning this to Gary 🍺

@Gergely
Copy link
Member

Gergely commented Jan 15, 2017


[15-Jan-2017 11:40:25 Europe/Budapest] PHP Stack trace:

[15-Jan-2017 11:40:25 Europe/Budapest] PHP   1. {main}() catalog\address_book_process.php:0

[15-Jan-2017 11:40:25 Europe/Budapest] PHP   2. OSC\OM\DbStatement->valueInt() catalog\address_book_process.php:118

[15-Jan-2017 11:40:25 Europe/Budapest] PHP   3. OSC\OM\DbStatement->valueMixed() catalog\includes\OSC\OM\DbStatement.php:228

Need zone id save like this:

$zone_id = (int)$Qzone->result[0]['zone_id'];

@Gergely
Copy link
Member

Gergely commented Jan 15, 2017

[15-Jan-2017 11:53:28 Europe/Budapest] PHP Notice:  Undefined index: zone_id in catalog\includes\OSC\OM\DbStatement.php on line 203

[15-Jan-2017 11:53:28 Europe/Budapest] PHP Stack trace:

[15-Jan-2017 11:53:28 Europe/Budapest] PHP   1. {main}() catalog\create_account.php:0

[15-Jan-2017 11:53:28 Europe/Budapest] PHP   2. OSC\OM\DbStatement->valueInt() catalog\create_account.php:152

[15-Jan-2017 11:53:28 Europe/Budapest] PHP   3. OSC\OM\DbStatement->valueMixed() catalog\includes\OSC\OM\DbStatement.php:228

https://github.com/Gergely/oscommerce2/tree/issue_520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants