blueprint: add map conversion check to fs customization unmarshaller #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an element in the `customizations.filesystem` array is not an object, the existing code would fail the conversion without an error, but would fail on the `d["mountpoint"].(type)` conversion, which produces an error message that isn't very useful: mountpoint must be string, got <nil> of type <nil> The commit catches the conversion error and instead prints a more useful error message.
achilleas-k
force-pushed
the
customizations/filesystem/toml/not-an-object
branch
from
20d2fc9
to
908c643
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
supakeen
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an element in the
customizations.filesystemarray is not an object, the existing code would fail the conversion without an error, but would fail on thed["mountpoint"].(type)conversion, which produces an error message that isn't very useful:The commit catches the conversion error and instead prints a more useful error message.