Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to OSCAL 1.1.3 #1795

Merged
merged 3 commits into from
Feb 11, 2025
Merged

feat: upgrade to OSCAL 1.1.3 #1795

merged 3 commits into from
Feb 11, 2025

Conversation

degenaro
Copy link
Collaborator

@degenaro degenaro commented Jan 9, 2025

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@degenaro
feat: upgrade to OSCAL 1.1.3
cb06162 
Signed-off-by: Lou DeGenaro <[email protected]>
@degenaro degenaro requested a review from a team as a code owner January 9, 2025 16:00
@degenaro degenaro self-assigned this Jan 10, 2025
@vikas-agarwal76 vikas-agarwal76 added this to the v3.8.0 milestone Jan 28, 2025
vikas-agarwal76
vikas-agarwal76 approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikas-agarwal76 vikas-agarwal76 requested a review from a team February 10, 2025 14:48
jpower432
jpower432 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One suggestion before merging or perhaps as a follow on PR before we cut the next release - update the OSCAL version supported in the README.

@degenaro
Copy link
Collaborator Author

LGTM. One suggestion before merging or perhaps as a follow on PR before we cut the next release - update the OSCAL version supported in the README.

Yes, an oversight. Fixed. Thx!

@degenaro degenaro merged commit ffc17c3 into develop Feb 11, 2025
14 checks passed
@degenaro degenaro deleted the feat/oscal-1.1.3 branch February 11, 2025 19:46
@jpower432 jpower432 linked an issue Feb 13, 2025 that may be closed by this pull request
Upgrade to OSCAL 1.1.3 #1758
Open
@jpower432 jpower432 mentioned this pull request Feb 13, 2025
Open
@degenaro degenaro mentioned this pull request Feb 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpower432 jpower432 jpower432 approved these changes

@vikas-agarwal76 vikas-agarwal76 vikas-agarwal76 approved these changes

Assignees

@degenaro degenaro

Labels
None yet
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

Upgrade to OSCAL 1.1.3
3 participants
@degenaro @jpower432 @vikas-agarwal76