From 0f44ec653ee4d24b537d6d4f5ef0cc96ca54a3b2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lars=20G=C3=B6ttgens?= <lars.goettgens@rwth-aachen.de>
Date: Fri, 23 Aug 2024 15:10:04 +0200
Subject: [PATCH] Small refactorings

- formatting
- add some parent type
- remove CoxeterGroup type as wished by felix-roehrich
---
 experimental/LieAlgebras/src/LieAlgebras.jl |  8 ++++++--
 experimental/LieAlgebras/src/Types.jl       | 13 +++++--------
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/experimental/LieAlgebras/src/LieAlgebras.jl b/experimental/LieAlgebras/src/LieAlgebras.jl
index 68d83db7f79f..81726acad82b 100644
--- a/experimental/LieAlgebras/src/LieAlgebras.jl
+++ b/experimental/LieAlgebras/src/LieAlgebras.jl
@@ -211,22 +211,26 @@ function number_of_simple_roots end
 
 include("Types.jl")
 include("Combinatorics.jl")
+include("Util.jl")
+
 include("CartanMatrix.jl")
 include("CoxeterGroup.jl")
 include("RootSystem.jl")
 include("DynkinDiagram.jl")
 include("WeylGroup.jl")
 
-include("Util.jl")
 include("LieAlgebra.jl")
 include("AbstractLieAlgebra.jl")
 include("LinearLieAlgebra.jl")
+include("DirectSumLieAlgebra.jl")
+
 include("LieSubalgebra.jl")
 include("LieAlgebraIdeal.jl")
 include("LieAlgebraHom.jl")
-include("DirectSumLieAlgebra.jl")
+
 include("LieAlgebraModule.jl")
 include("LieAlgebraModuleHom.jl")
+
 include("iso_oscar_gap.jl")
 include("iso_gap_oscar.jl")
 include("GapWrapper.jl")
diff --git a/experimental/LieAlgebras/src/Types.jl b/experimental/LieAlgebras/src/Types.jl
index e291e3b8550f..bfbfd8810832 100644
--- a/experimental/LieAlgebras/src/Types.jl
+++ b/experimental/LieAlgebras/src/Types.jl
@@ -6,12 +6,11 @@
 
 @attributes mutable struct RootSystem
   cartan_matrix::ZZMatrix # (generalized) Cartan matrix
-  #fw::QQMatrix # fundamental weights as linear combination of simple roots
   positive_roots::Vector #::Vector{RootSpaceElem} (cyclic reference)
   positive_roots_map::Dict{QQMatrix,Int}
   positive_coroots::Vector #::Vector{DualRootSpaceElem} (cyclic reference)
   positive_coroots_map::Dict{QQMatrix,Int}
-  weyl_group::Any     #::WeylGroup (cyclic reference)
+  weyl_group::Any #::WeylGroup (cyclic reference)
 
   # optional:
   type::Vector{Tuple{Symbol,Int}}
@@ -81,8 +80,6 @@ end
 #
 ###############################################################################
 
-abstract type CoxeterGroup end
-
 @attributes mutable struct WeylGroup <: AbstractAlgebra.Group
   finite::Bool              # finite indicates whether the Weyl group is finite
   refl::Matrix{UInt}        # see positive_roots_and_reflections
@@ -147,9 +144,9 @@ end
 #
 ###############################################################################
 
-abstract type LieAlgebra{C<:FieldElem} end
+abstract type LieAlgebra{C<:FieldElem} <: AbstractAlgebra.Set end
 
-abstract type LieAlgebraElem{C<:FieldElem} end
+abstract type LieAlgebraElem{C<:FieldElem} <: AbstractAlgebra.SetElem end
 
 ###############################################################################
 # AbstractLieAlgebra
@@ -408,7 +405,7 @@ end
 #
 ###############################################################################
 
-@attributes mutable struct LieAlgebraModule{C<:FieldElem}
+@attributes mutable struct LieAlgebraModule{C<:FieldElem} <: AbstractAlgebra.Set
   L::LieAlgebra{C}
   dim::Int
   transformation_matrices::Vector{MatElem{C}}
@@ -436,7 +433,7 @@ end
   end
 end
 
-struct LieAlgebraModuleElem{C<:FieldElem}
+struct LieAlgebraModuleElem{C<:FieldElem} <: AbstractAlgebra.SetElem
   parent::LieAlgebraModule{C}
   mat::MatElem{C}
 end