Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🦓 Breaking: update server public_ipv4_count to 0 #30

Open
1 of 2 tasks
oscarhermoso opened this issue Oct 12, 2024 · 0 comments
Open
1 of 2 tasks

🦓 Breaking: update server public_ipv4_count to 0 #30

oscarhermoso opened this issue Oct 12, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@oscarhermoso
Copy link
Owner

oscarhermoso commented Oct 12, 2024 •
edited
Loading

Think this breaking change is worth applying, update default value of public_ipv4_count to 0

Pros:

  • Secure by default (no accidentally exposed servers)
  • Reduce IPv4 usage - something that binarylane don't have in large supply

Downsides:

  • Slightly more boilerplate for anyone who wanted to host a simple server

Steps

  • Start off by making public_ipv4_count a required attribute now
  • Change default to 0 with v1.0 release of the provider
@oscarhermoso oscarhermoso added the enhancement New feature or request label Oct 12, 2024
@oscarhermoso oscarhermoso mentioned this issue Nov 2, 2024
Merged
@oscarhermoso oscarhermoso changed the title Breaking: update server public_ipv4_count to 0 🦓 Breaking: update server public_ipv4_count to 0 Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oscarhermoso