Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified: BinaryInteger testing #108

Closed
oscbyspro opened this issue Oct 2, 2024 · 3 comments
Closed

Unified: BinaryInteger testing #108

oscbyspro opened this issue Oct 2, 2024 · 3 comments
Labels
brrr such code, much wow

Comments

@oscbyspro
Copy link
Owner

I want to test all binary integers in a single place because maintaining multiple testing strategies is just too much work. I'm happy with the fuzzing approach, so I'll focus more on that. Ideally, I'll reduce it to a single—unified—testing module, but I'm unsure how realistic that is. We'll see.

@oscbyspro oscbyspro added the brrr such code, much wow label Oct 2, 2024
@oscbyspro oscbyspro changed the title Unified: binary integer tests Unified: BinaryInteger tests Oct 2, 2024
@oscbyspro oscbyspro changed the title Unified: BinaryInteger tests Unified: BinaryInteger testing Oct 3, 2024
@oscbyspro oscbyspro added this to the Ultimathnum 0.11.0 milestone Oct 4, 2024
oscbyspro added a commit that referenced this issue Oct 13, 2024
Something, something, lots of fuzzing.
@oscbyspro
Copy link
Owner Author

oscbyspro commented Oct 14, 2024

I could hoist DoubleInt's 2-by-1-as-3 multiplication tests if it were available to HalveableInteger (#60).

oscbyspro added a commit that referenced this issue Oct 20, 2024
Lots and lots and lots and lots and lots and lots and lots of fuzzing.
oscbyspro added a commit that referenced this issue Oct 21, 2024
oscbyspro added a commit that referenced this issue Oct 21, 2024
oscbyspro added a commit that referenced this issue Oct 23, 2024
Lots and lots and lots and lots and lots and lots and lots of fuzzing.
oscbyspro added a commit that referenced this issue Oct 24, 2024
Lots and lots and lots and lots and lots and lost and lots of fuzzing.
oscbyspro added a commit that referenced this issue Oct 24, 2024
We now test infinite values too and avoid silently wrapping expectations.
oscbyspro added a commit that referenced this issue Oct 26, 2024
Lots and lots and lots and lots and lots and lots and lots of fuzzing.
@oscbyspro
Copy link
Owner Author

oscbyspro commented Nov 3, 2024

I managed to unify all CoreInteger tests and all InfiniInt<T> tests and all but two DoubleInt<T> tests (#60). I also found one bug that I would not have found otherwise (#123). StdlibInt<T> still requires a separate testing strategy, but I am pleased with the result.

@oscbyspro
Copy link
Owner Author

oscbyspro commented Nov 3, 2024

Looks like BinaryInteger+Addition.swift was removed in (d8213e6). I'll bring it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brrr such code, much wow
Projects
None yet
Development

No branches or pull requests

1 participant