Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using HTML templates for newsletter emails #18

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Using HTML templates for newsletter emails #18

merged 1 commit into from
Jun 1, 2021

Conversation

PrimalPimmy
Copy link
Member

Fixes #13 , in progress.

@daemon1024
Copy link
Member

Can you attach the screenshot here as well? Also maybe update the PR heading to something more relevant like "using templates for html emails" or better.

@PrimalPimmy PrimalPimmy changed the title Prettifying newsletter mail Using HTML templates for newsletter emails. Jun 1, 2021
@PrimalPimmy
Copy link
Member Author

Basic layout.
image

Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run the formatter once? There are some random new lines and unaligned code. Rest LGTM

@daemon1024 daemon1024 changed the title Using HTML templates for newsletter emails. Using HTML templates for newsletter emails Jun 1, 2021
@daemon1024 daemon1024 merged commit ae26931 into osdc:main Jun 1, 2021
@PrimalPimmy PrimalPimmy deleted the Mail branch June 2, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prettify email
2 participants