Merge pull request #952 from oslokommune/button-cleanup

Use shorter labels for certain buttons
oslokommune · Dec 21, 2023 · 76a1e2d · 76a1e2d
2 parents 2aee9e4 + 52b4422
commit 76a1e2d
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 7 deletions.
diff --git a/src/components/panes/ObjectivePane.vue b/src/components/panes/ObjectivePane.vue
@@ -42,6 +42,7 @@
         <pkt-button
           v-if="hasEditRights || isMemberOfChild"
           :text="$t('general.keyResult')"
+          :aria-label="$t('btn.addKeyResult')"
           skin="primary"
           size="small"
           variant="icon-left"

diff --git a/src/components/panes/TimelinePane.vue b/src/components/panes/TimelinePane.vue
@@ -15,7 +15,8 @@
     <template #actions>
       <pkt-button
         v-if="hasEditRights"
-        :text="$t('btn.createObjective')"
+        :text="$t('general.objective')"
+        :aria-label="$t('btn.createObjective')"
         skin="primary"
         size="small"
         variant="icon-left"

diff --git a/src/components/widgets/WidgetKpiProgressGraph.vue b/src/components/widgets/WidgetKpiProgressGraph.vue
@@ -7,15 +7,17 @@
           skin="primary"
           variant="icon-left"
           icon-name="plus-sign"
+          :aria-label="$t('kpi.newValue')"
           @onClick="$emit('add-value')"
         >
-          {{ $t('kpi.newValue') }}
+          {{ $t('kpi.value') }}
         </pkt-button>
         <pkt-button
           size="small"
           skin="tertiary"
           variant="icon-left"
           icon-name="bullseye"
+          :aria-label="$t('kpi.goals.set')"
           @onClick="$emit('set-goals')"
         >
           {{ $t('kpi.goals.set') }}
@@ -28,6 +30,7 @@
         skin="tertiary"
         variant="icon-left"
         icon-name="download"
+        :aria-label="$t('dashboard.downloadOptions.png')"
         @onClick="download"
       >
         {{ $t('btn.download') }}

diff --git a/src/locale/locales/en-US.json b/src/locale/locales/en-US.json
@@ -20,6 +20,7 @@
     "currentValue": "Current value",
     "latestValueTitle": "Latest value per {formattedDate}",
     "progress": "Progress",
+    "value": "Value",
     "newValue": "New value",
     "editValue": "Edit value",
     "description": "Description",
@@ -166,6 +167,7 @@
     "OKRs": "OKRs",
     "OKRsLong": "Objectives and Key results",
     "OKRsLonger": "Objectives and Key results for {name}",
+    "KPI": "Measurement",
     "KPIs": "Measurements",
     "KPIsLong": "Measurements for {name}",
     "project": "OKR",
@@ -207,8 +209,6 @@
     "displayedAs": "Displayed as: ",
     "today": "Today",
     "view": "View",
-    "newObjective": "New objective",
-    "newKeyResult": "New key result",
     "step": "Step {step} of {steps}",
     "or": "or",
     "shortcuts": "Shortcuts",

diff --git a/src/locale/locales/nb-NO.json b/src/locale/locales/nb-NO.json
@@ -20,6 +20,7 @@
     "currentValue": "Nåværende verdi",
     "latestValueTitle": "Siste verdi per {formattedDate}",
     "progress": "Progresjon",
+    "value": "Målepunkt",
     "newValue": "Legg til målepunkt",
     "editValue": "Endre målepunkt",
     "description": "Beskrivelse",
@@ -166,6 +167,7 @@
     "OKRs": "OKR-er",
     "OKRsLong": "Mål og nøkkelresultater",
     "OKRsLonger": "Mål og nøkkelresultater for {name}",
+    "KPI": "Måling",
     "KPIs": "Målinger",
     "KPIsLong": "Målinger for {name}",
     "project": "OKR",
@@ -207,8 +209,6 @@
     "displayedAs": "Vises som: ",
     "today": "I dag",
     "view": "Visning",
-    "newObjective": "Nytt mål",
-    "newKeyResult": "Nytt nøkkelresultat",
     "step": "Steg {step} av {steps}",
     "or": "eller",
     "shortcuts": "Snarveier",

diff --git a/src/views/Item/ItemMeasurements.vue b/src/views/Item/ItemMeasurements.vue
@@ -14,7 +14,8 @@
 
     <div v-if="hasEditRights" class="measurements-page__actions">
       <pkt-button
-        :text="$t('admin.measurement.new')"
+        :text="$t('general.KPI')"
+        :aria-label="$t('admin.measurement.new')"
         skin="primary"
         size="small"
         variant="icon-left"