-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unclear what kind of feedback is welcome #344
Comments
Definitely not "we support this areas, do not bother us about other". Of the latter two I will leave further commentary to those who are actually working on shields and can state whether links to SVGs is a sufficient starting point. One thought: We could create an issue template for new shields that also includes prompts for the other information we need, like which |
The style contribution guidelines are at style/CONTRIBUTE.md. I considered making issue templates a while back, one of which would be for requesting support for missing highway shields. I think this would be valuable, though we should think it through and have templates for every kind of issue. In short, feel free to write up an issue describing the the current tagging of the route network in question, with example images. PRs are also welcome, though obviously they're a little more work. |
Ops. #345 attempts to eliminate source of confusion |
I don’t see a point to having project-wide files in the style/ folder. We should move them into the root folder – not only the contributing guide but also package.json to support reuse: #146. |
If file can be moved to root of project, then it would be even better |
I'm fine centralizing the contrib stuff in root. The intent of the separate style folder was to have a sibling folder that would have custom layer generation code. Since we'd need to revision control them together, I think it makes sense for them to share a repo. However, there's no reason we can't move project-wide stuff up a folder. |
I support moving the following files into the project root. That's where they typically live in most projects. Having them in a subfolder is atypical.
|
@matkoniecz is the concern expressed in this ticket satisfactorily resolved? If so, I'd propose to close this ticket and start a new one describing the collapsing of the style subfolder into the repository root. If not, what more is needed beyond #345? |
yes, this one is solved feel free to create one tracking
|
https://github.com/osm-americana/openstreetmap-americana#coverage - should it be treated as "we support this areas, do not bother us about other"?
Or "we support this areas, feel free to make PR adding support for other"?
Or "we support this area, feel free to make issue about missing shields elsewhere"?
Asking as I was unsure whether making issue about shields missing in Poland, with no intention of making PR I would provide links to SVG shields. Would it be welcome and useful contribution or not?
BTW, CONTRIBUTING.MD file is also missing.
The text was updated successfully, but these errors were encountered: