Skip to content

Commit

Permalink
tweak use of abbreviated thoroughbass in grading
Browse files Browse the repository at this point in the history
  • Loading branch information
ospreyelm committed Aug 24, 2020
1 parent f167451 commit f2bc0ea
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion lab/static/js/src/models/exercise_grader.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ define([
.filter( function(key) {return definition.exercise.analysis.mode[key];} )
.filter( function(mode) {return supported.includes(mode);} );
var abbrev_switch = definition.exercise.analysis.mode.abbreviate_thoroughbass;
abbrev_switch = false; // assessments by abbreviated figure would be flawed in most cases
}

for(i = 0, len = problems.length; i < len; i++) {
Expand All @@ -96,6 +95,9 @@ define([
result = this.analysisPcsMatch(expected_notes, actual_notes, analysis_types);
break;
case "figured_bass":
// Assessments by abbreviated figure would be flawed in most cases,
// in the absence of pitch-class checks
abbrev_switch = false;
result = this.figuredBassMatch(expected_notes, actual_notes, abbrev_switch);
break;
case "figured_bass_pcs":
Expand Down

0 comments on commit f2bc0ea

Please sign in to comment.