Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ROS_SYNC_DATE to dockerfile busting cache for each sync #775

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Add ROS_SYNC_DATE to dockerfile busting cache for each sync #775

merged 2 commits into from
Nov 22, 2024

Conversation

mikaelarguedas
Copy link
Contributor

@mikaelarguedas mikaelarguedas commented Oct 30, 2024 •
edited
Loading

Update generated dockerfiles based on osrf/docker_templates#110

Wil solve #112 as the dockerfiles will be outdated and regenerated at each sync.

@ruffsl
Copy link
Member

ruffsl commented Oct 30, 2024

Related discussion: #753 (comment)

@mikaelarguedas
Copy link
Contributor Author

mikaelarguedas commented Oct 30, 2024 •
edited
Loading

@nuclearsandwich @tfoote what do you think about this approach ?
Some assumptions are made here:

  • the fact that a tag <DISTRO_NAME>/<SYNC_DATE> exists on rosdistro implies that the packages for that sync are available on the main apt repo
  • that the last tag in the sorted list of tags matching that distro is the latest (basically that the format <DISTRO_NAME>/YYYY-MM-DD will be the only one used on rosdistro

How do you feel about adding a new environment variable that is not provided by ros_environment ?
Any feedback on the ROS_SYNC_DATE variable naming ?

@mikaelarguedas mikaelarguedas merged commit d95755e into master Nov 22, 2024
14 checks passed
@mikaelarguedas mikaelarguedas deleted the ros_sync_date branch November 22, 2024 20:32
@mikaelarguedas
Copy link
Contributor Author

upstream PR: docker-library/official-images#17960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavanderhoorn gavanderhoorn gavanderhoorn left review comments

@ruffsl ruffsl ruffsl approved these changes

@tfoote tfoote Awaiting requested review from tfoote

@nuclearsandwich nuclearsandwich Awaiting requested review from nuclearsandwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikaelarguedas @ruffsl @gavanderhoorn