Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Room-reservation system #357

Open
luisgreg99 opened this issue Feb 20, 2020 · 0 comments
Open

upgrade Room-reservation system #357

luisgreg99 opened this issue Feb 20, 2020 · 0 comments
Labels

Comments

@luisgreg99
Copy link
Contributor

luisgreg99 commented Feb 20, 2020

Descriptive summary

Options:

a) Upgrade to Rails 5:

Upgrading to Rails 5 can resolve this issue #355

In order to resolve #355, I tried to upgrade to gem 'sass-rails', '~>6.0', and I found that it also requires at least sprockets 3.7.2. I pushed the update in this branch upgrade/sass-rails-from-2-to-6 for testing.

It looks like sass-rails should be automatically updated to 6 with #354, which was recently posted by GitHub dependabot. This updates sass-rails to 6 and sprockets to 4, but it also does a rails upgrade from 4.2.11 to 5.2.4.1. I think #354 should resolve this update, but it needs additional changes since rails 5 requires these updates to the codebase to bump to rails 5: https://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-4-2-to-rails-5-0

b) Rebuild with latest rails

Related work

#355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant