Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iso format #604

Open
junio256 opened this issue Jan 18, 2024 · 3 comments
Open

Add iso format #604

junio256 opened this issue Jan 18, 2024 · 3 comments
Labels
format-request waiting ecosystem Waiting for other crates in ecosystem

Comments

@junio256
Copy link

First, thank you very much for maintaining this, it has been a life changer using your app!
I don't know if this will be against the app principle, but .ISO is the only format that I commonly find that isn't supported on ouch, afaik.
Since 7z has support to decompress these types of files, I thought that would be a good idea to implement it.

@junio256 junio256 added the enhancement New feature or request label Jan 18, 2024
@marcospb19 marcospb19 added the PR-welcome Suggestion was approved, but now we need someone to volunteer for doing it label Feb 28, 2024
@marcospb19
Copy link
Member

Thanks for the issue, I've added the "PR-welcome" label for anyone who wants to pick this up.

I don't know much about .iso tho, so if someone finds a drawback or concern, please tell them.

@junio256
Copy link
Author

Extracting is way easier than compacting since it has to implement a ton of features (drawback of following ISO_9660 standard)

Searched through crates.io and there was no sign of an ISO extrator (at least completed), so implementing by hand might be necessary.
For reference, this is 7z C++ files: https://github.com/ip7z/7zip/tree/5b39dc76f1bc82f941d5c800ab9f34407a06b53a/CPP/7zip/Archive/Iso
And a Wikipedia article detailing how it is done: https://en.wikipedia.org/wiki/ISO_9660
I don't have many experience with ISO either but I can try ~

@marcospb19
Copy link
Member

Searched through crates.io and there was no sign of an ISO extrator (at least completed), so implementing by hand might be necessary.

Ouch doesn't implement any format-specific packing or unpacking, so we'd need to wait for a crate in the ecosystem.

@marcospb19 marcospb19 added the waiting ecosystem Waiting for other crates in ecosystem label Mar 2, 2024
@marcospb19 marcospb19 added format-suggestion format-request and removed enhancement New feature or request PR-welcome Suggestion was approved, but now we need someone to volunteer for doing it format-suggestion labels Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format-request waiting ecosystem Waiting for other crates in ecosystem
Projects
None yet
Development

No branches or pull requests

2 participants