Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Contribute" button link on home page #89

Open
ericis opened this issue Dec 3, 2021 · 5 comments
Open

Fix "Contribute" button link on home page #89

ericis opened this issue Dec 3, 2021 · 5 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ericis
Copy link
Member

ericis commented Dec 3, 2021

"Contribute" does not link to the contributor page:
https://www.ourchitecture.io/hello-cloud/

@ericis ericis added bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed labels Dec 3, 2021
@sanket95droid
Copy link

Hey I just made some changes to the functionality of Contribute button, please check them out : #92 (comment)

@ericis
Copy link
Member Author

ericis commented Dec 3, 2021

Hey @sanket95droid . Thank you for the contribution. The "./docs" folder is automatically generated output, so we actually need to fix this in "./src/docs/index.md". Let's start a new PR with this change.

Is that clear and helpful?

If you have GNU make and docker installed, you may run make start-docs, open http://localhost:8000/hello-cloud/contribute/, and then make edits to the markdown files (changes should automatically update in the browser). When done, you can run make stop-docs to stop the docker container.

@ericis
Copy link
Member Author

ericis commented Dec 10, 2021

@sanket95droid do you still want to work this issue with the above process? I can assign it to you if so.

@sanket95droid
Copy link

I'll study the issue a bit more then work on it.

@ericis
Copy link
Member Author

ericis commented Dec 13, 2021

Feel free to ask any questions and I will try to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants