Skip to content

Commit

Permalink
Fix PHP 8 support
Browse files Browse the repository at this point in the history
  • Loading branch information
Tarpsvo committed Oct 22, 2020
1 parent a0d7829 commit fcfddb4
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions src/NovaTranslationsLoader.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ class NovaTranslationsLoader extends ServiceProvider
protected $packageName;
protected $publishTranslations;

public function __construct($packageTranslationsDir = __DIR__, $packageName, $publishTranslations = true)
public function __construct($packageTranslationsDir, $packageName, $publishTranslations = true)
{
$this->app = app();
$this->packageTranslationsDir = $packageTranslationsDir;
$this->packageTranslationsDir = $packageTranslationsDir ?? __DIR__ . '/../resources/lang';
$this->packageName = $packageName;
$this->publishTranslations = $publishTranslations;
}
Expand All @@ -29,8 +29,9 @@ public function __construct($packageTranslationsDir = __DIR__, $packageName, $pu
* @param boolean $publishTranslations Whether to also automatically make translations publishable.
* @return null
**/
public static function loadTranslations($packageTranslationsDir = __DIR__, $packageName, $publishTranslations = true)
public static function loadTranslations($packageTranslationsDir, $packageName, $publishTranslations = true)
{
$packageTranslationsDir = $packageTranslationsDir ?? __DIR__ . '/../resources/lang';
$packageTranslationsDir = rtrim($packageTranslationsDir, '/');
$packageName = trim($packageName);

Expand Down

0 comments on commit fcfddb4

Please sign in to comment.