Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add country object #3

Open
dwillis opened this issue Jul 30, 2016 · 6 comments
Open

Add country object #3

dwillis opened this issue Jul 30, 2016 · 6 comments
Assignees

Comments

@dwillis
Copy link
Collaborator

dwillis commented Jul 30, 2016

Create a Country class that has methods for grabbing players by first letter of last name, grounds, fixtures (possibly use iCal format), international results, maybe domestic results?.

@dwillis dwillis self-assigned this Jul 30, 2016
@ghost
Copy link

ghost commented Jul 31, 2016

Baby steps, but I'm focusing on grabbing players by first letter of last name.

It seems kinda counterintuitive to me to be grabbing players by last name instead of grabbing all players and then filtering.

Also, it would be useful if the players could be represented as data frames instead of manually having to access each stat.

Let me know what you think.

@dwillis
Copy link
Collaborator Author

dwillis commented Jul 31, 2016

The grabbing by last name is just to get their IDs for parsing - the Player class will allow you to specific a specific ID. I agree that it would be useful to be able to grab multiple players at once. What do you think the API for that looks like?

@ghost
Copy link

ghost commented Jul 31, 2016

I was thinking of having some kind of a player combiner kind of object that combined multiple players and spat out a dataframe or similar.

@dwillis
Copy link
Collaborator Author

dwillis commented Aug 1, 2016

That makes sense to me. Could it return a dataframe or serialized JSON?

@ghost
Copy link

ghost commented Aug 1, 2016

Either would work. I've been spending a lot of time in R lately so everything's looking like a dataframe ;)

@dwillis
Copy link
Collaborator Author

dwillis commented Aug 1, 2016

Heh, cool. This library tries to return Python objects where possible and JSON as a fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant