Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite/update Match class #60

Open
dwillis opened this issue Jul 26, 2023 · 0 comments
Open

Rewrite/update Match class #60

dwillis opened this issue Jul 26, 2023 · 0 comments

Comments

@dwillis
Copy link
Collaborator

dwillis commented Jul 26, 2023

Is your feature request related to a problem? Please describe.
Cricinfo has added JSON APIs that provide additional information and data that would be useful to have. At the same time, the existing Match class is too brittle and probably contains too many methods that aren't very useful.

Describe the solution you'd like
Add support for additional data available through newer API endpoints (example here), remove any existing methods that no longer work and in general make the Match class slimmer and more maintainable. The batting & bowling stats should not rely on the existing comms_json method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant