New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment to client models.ts checkpoints architecture oddity #6

Open

mncharity opened this issue Oct 10, 2018 · 1 comment

mncharity commented Oct 10, 2018 •

edited

Loading

client/src/models.ts currently says:

  1.01: {
    url: BASE_URL + 'mobilenet_v1_101/',
    architecture: posenet.mobileNetArchitectures[100]
  },
  1.0: {
    url: BASE_URL + 'mobilenet_v1_100/',
    architecture: posenet.mobileNetArchitectures[100]
  },
  0.75: {
    url: BASE_URL + 'mobilenet_v1_075/',
    architecture: posenet.mobileNetArchitectures[75]
  },

The 1.01 architecture 100 is correct, but has the look of a typo, which can trigger review. So perhaps add a reassuring comment?

    architecture: posenet.mobileNetArchitectures[100] // same as 1.0

Thanks for your work.

The text was updated successfully, but these errors were encountered:

Owner

oveddan commented Oct 10, 2018

Yes this is correct. Feel free to submit a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment