diff --git a/changelog.d/20231003_133500_dave_remove_trailing_slash.md b/changelog.d/20231003_133500_dave_remove_trailing_slash.md new file mode 100644 index 00000000..36416779 --- /dev/null +++ b/changelog.d/20231003_133500_dave_remove_trailing_slash.md @@ -0,0 +1,11 @@ + + + +- [Bugfix] Remove the trailing slash from auto-generated PUBLIC_PATH env vars for MFEs in order to be consistent with LMS/Studio config, and so that we don't have to strip it off on the JavaScript side after the React Router 6 upgrade. (by @ormsbee) diff --git a/tutormfe/templates/mfe/build/mfe/Dockerfile b/tutormfe/templates/mfe/build/mfe/Dockerfile index f0d74c26..f0050fda 100644 --- a/tutormfe/templates/mfe/build/mfe/Dockerfile +++ b/tutormfe/templates/mfe/build/mfe/Dockerfile @@ -72,7 +72,7 @@ EXPOSE {{ app['port'] }} # Configuration needed at build time ENV APP_ID={{ app_name }} -ENV PUBLIC_PATH='/{{ app_name }}/' +ENV PUBLIC_PATH='/{{ app_name }}' # We could in theory point the mfe_config API directly to the LMS. But for that we would # have to code the LMS url into the mfe image, and this configuration is user-dependent. # So we point to a relative url that will be a proxy for the LMS.