From 9671824e1f0071bbe8fd587a1ac7445af31f978b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9gis=20Behmo?= Date: Fri, 21 Jun 2024 16:59:34 +0200 Subject: [PATCH] fix: docker build deprecation warnings With the latest Docker upgrade, we got the following warnings during build: FromAsCasing: 'as' and 'FROM' keywords' casing do not match LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format --- changelog.d/20240621_170044_regis.md | 1 + tutornotes/templates/notes/build/notes/Dockerfile | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 changelog.d/20240621_170044_regis.md diff --git a/changelog.d/20240621_170044_regis.md b/changelog.d/20240621_170044_regis.md new file mode 100644 index 0000000..d7d2eb7 --- /dev/null +++ b/changelog.d/20240621_170044_regis.md @@ -0,0 +1 @@ +- [Bugfix] Fix legacy warnings during Docker build. (by @regisb) diff --git a/tutornotes/templates/notes/build/notes/Dockerfile b/tutornotes/templates/notes/build/notes/Dockerfile index d78dfae..4fea8b4 100644 --- a/tutornotes/templates/notes/build/notes/Dockerfile +++ b/tutornotes/templates/notes/build/notes/Dockerfile @@ -15,7 +15,7 @@ RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \ pkg-config && \ sed -i '/en_US.UTF-8/s/^# //g' /etc/locale.gen && \ locale-gen -ENV LC_ALL en_US.UTF-8 +ENV LC_ALL=en_US.UTF-8 ###### Git-clone Notes repo ###### ARG APP_USER_ID=1000 @@ -27,7 +27,7 @@ WORKDIR /app/edx-notes-api ###### Install python venv ###### RUN python -m venv /app/venv -ENV PATH /app/venv/bin:${PATH} +ENV PATH=/app/venv/bin:${PATH} # https://pypi.org/project/setuptools/ # https://pypi.org/project/pip/ # https://pypi.org/project/wheel/