Upgrade to Sumac #1139
Open
Upgrade to Sumac #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required when upgrading from Tutor v15 to v18 directly MySQL does not allow direct upgrades from v5.7 to v8.4
Content Libraries will store asset files like images, transcripts, and PDFs using Learning Core–which in turn uses django-storages and expects some backing file store. These files should NOT be directly accessible via the browser, both because of access policies and the fact that the filenames will not be meaningful by themselves and must be translated by app logic. For details see: * https://github.com/openedx/openedx-learning/blob/main/docs/decisions/0015-serving-static-assets.rst * https://github.com/openedx/openedx-learning/blob/main/openedx_learning/apps/authoring/contents/models.py * https://github.com/openedx/openedx-learning/blob/main/openedx_learning/apps/authoring/components/models.py The existing /data/openedx-media -> /openedx/media mount is publicly accessible by browser, and so is not appropriate for this purpose. This commit creates a parallel /data/openedx-media-private -> /openedx/media-private volume mapping instead. This commit also creates configuration needed for openedx-learning to point to this new directory. This commit does NOT currently add support for this in k8s, as that will require changes to the minio plugin.
DawoudSheraz
force-pushed
the
sumac
branch
2 times, most recently
from
39ab257
to
2cbe2f2
Compare
* feat: update Open edX image to use ubuntu 22.04 as base OS
…to Redwood (#1140) * ix: run MySQL 8.1 as a separate container during upgrade from Olive to Redwood We do this because MySQL 8.1 does not have the --mysql-native-password option We have this option turned on for backward compatibility
When uwsgi runs with xml support, it throws the following error on startup with the latest version of edx-platform: ``` xmlsec.InternalError: (-1, 'lxml & xmlsec libxml2 library version mismatch') ``` See xmlsec/python-xmlsec#320 for more details on this. Essentially, the uWSGI wheel is built against a different version of libxml2 and it causes this version mismach error when trying to load xmlsec. The xml support in uWSGI is only needed for runing with xml configuration files, which tutor does not do. Following the guidance of the above issue, I updated the `openedx` Dockerfile to no longer compile with any xml support as a part of the build. The time to build uWSGI was only slightly more than building from cache so I'm not concerned about major slowdowns in the build time for un-cached builds.
jfavellar90
reviewed
Nov 20, 2024
| # Additional service for watching theme changes | ||
| watchthemes: | ||
| <<: *openedx-service | ||
| command: npm run watch-sass | ||
| restart: unless-stopped | ||
|
|
||
| {% if RUN_ELASTICSEARCH and is_docker_rootless() %} |
There was a problem hiding this comment.
Since we no longer use ElasticSearch, can we remove the is_docker_rootless method? This is the PR where the function was created, it is not invoked anywhere else
There was a problem hiding this comment.
Yes!!! I love deleting code. @Faraz32123 please note that you will need to add the is_docker_rootless template filter to your discovery PR.
With this change, we get rid of Elasticsearch across all of Tutor. Instead, we run Meilisearch, which is much more lightweight in terms of memory usage. Obviously, this is a (very) breaking change. Indexing commands will be run during init, such that search should work as before. After the edx-search PR is merged and the dependency is upgraded in edx-platform, we should remove the manual `RUN pip install ...` command.
In Sumac, it was decided that we would not automatically migrating data from mongodb to mysql. Instead, we encourage users to do so manually, in the tutor-forum README.
This filter was used only by Elasticsearch, so we no longer need to include it in Tutor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v19.0.0 sumac release
Todos before merge
OPENEDX_COMMON_VERSIONis pointing to correct tagopen-release/sumac.1Merge Option