Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apply mysqld character set fix to Kubernetes deployment #896

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

fghaas
Copy link
Contributor

@fghaas fghaas commented Aug 24, 2023

This is a follow-up fix to #890, where the corresponding change was added to the mysqld invocation in the "tutor local" (that is, docker-compose) deployment method, but omitted from its "tutor k8s" equivalent.

@fghaas
Copy link
Contributor Author

fghaas commented Aug 24, 2023

This is a somewhat speculative change that I am submitting pending the outcome of the discussion in #890 — this is why this PR is currently marked as a Draft.

This is a follow-up fix to overhangio#819, where the corresponding change was
added to the mysqld invocation in the "tutor local" (that is,
docker-compose) deployment method, but omitted from its "tutor k8s"
equivalent.
@fghaas fghaas changed the title fix: Apply mysqld character set upgrade to Kubernetes deployment fix: Apply mysqld character set fix to Kubernetes deployment Aug 24, 2023
@regisb regisb marked this pull request as ready for review August 28, 2023 07:50
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 100% right, so I moved the PR away from draft mode. There's even a changelog entry! Let's merge this right away.

@regisb regisb merged commit cc1d5a9 into overhangio:master Aug 28, 2023
1 check passed
@regisb
Copy link
Contributor

regisb commented Aug 28, 2023

Thanks a lot @fghaas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants