-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chart-sync: use more informative user name in approval tool #2377
Comments
Good idea, though might not be trivial if we don't know how to effectively do development chart revision tool. (Could be also parked until we decide to refactor it in streamlit) |
Related to #2465 |
(quick follow-up on this issue) Recently I thought of a quick win in this domain, and it occurred to me that we could add some note in the "Reason for suggested revision" field, which is shown at the bottom of the suggestion (see screenshot) and comes from the field We might move the chart approval tool to Streamlit at some point, so this solution doesn't take much time. This quick solution wouldn’t provide filtering, but it could be a hacky way to see where that revision comes from without touching any typescript. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This is no longer on the roadmap, given that we will be switching to a new workflow: #2580 |
Problem
Currently, when a user uses the chart-sync, all charts modified in the source server are put in the queue of the chart approval tool under the user name "ETL":
This could be more informative. Instead, we could label it according to the branch that created the staging server, e.g. "fix/population".
Technical notes
This is a bit tricky, as the
SuggestedChartRevisions
object is created with the user ID (and not user name). Key code to change:The text was updated successfully, but these errors were encountered: