Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart-sync: use more informative user name in approval tool #2377

Closed
lucasrodes opened this issue Mar 5, 2024 · 5 comments
Closed

chart-sync: use more informative user name in approval tool #2377

lucasrodes opened this issue Mar 5, 2024 · 5 comments
Labels
priority 3 - nice to have wontfix This will not be worked on

Comments

@lucasrodes
Copy link
Member

lucasrodes commented Mar 5, 2024

Problem

Currently, when a user uses the chart-sync, all charts modified in the source server are put in the queue of the chart approval tool under the user name "ETL":

image

This could be more informative. Instead, we could label it according to the branch that created the staging server, e.g. "fix/population".

Technical notes

This is a bit tricky, as the SuggestedChartRevisions object is created with the user ID (and not user name). Key code to change:

@lucasrodes lucasrodes changed the title chart-sync: use more informative session name chart-sync: use more informative user name in approval tool Mar 5, 2024
@Marigold
Copy link
Collaborator

Marigold commented Mar 6, 2024

Good idea, though might not be trivial if we don't know how to effectively do development chart revision tool. (Could be also parked until we decide to refactor it in streamlit)

@larsyencken
Copy link
Contributor

Related to #2465

@lucasrodes
Copy link
Member Author

(quick follow-up on this issue)

Recently I thought of a quick win in this domain, and it occurred to me that we could add some note in the "Reason for suggested revision" field, which is shown at the bottom of the suggestion (see screenshot) and comes from the field suggestedReason in table suggested_chart_revisions.

image

We might move the chart approval tool to Streamlit at some point, so this solution doesn't take much time.

This quick solution wouldn’t provide filtering, but it could be a hacky way to see where that revision comes from without touching any typescript.

Copy link

stale bot commented May 27, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 27, 2024
@lucasrodes
Copy link
Member Author

This is no longer on the roadmap, given that we will be switching to a new workflow: #2580

@larsyencken larsyencken closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority 3 - nice to have wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants