Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data diff: strict checks when no changes expected #2391

Closed
Tracked by #2390
larsyencken opened this issue Mar 8, 2024 · 1 comment
Closed
Tracked by #2390

Data diff: strict checks when no changes expected #2391

larsyencken opened this issue Mar 8, 2024 · 1 comment
Assignees

Comments

@larsyencken
Copy link
Collaborator

larsyencken commented Mar 8, 2024

What

When a PR body says "No data changes expected", make the data diff check strict (i.e. fail with a red cross on any differences).

Why / Why now?

  • Today we ignore data diff because it is never green or red
  • To make it useful, we should let it fail if no changes are expected
    • This will help it catch cases where we didn't intend to cause changes
Copy link

stale bot commented May 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 9, 2024
@stale stale bot closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants