Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with long URLs in staging servers #2532

Closed
pabloarosado opened this issue Apr 17, 2024 · 2 comments
Closed

Problems with long URLs in staging servers #2532

pabloarosado opened this issue Apr 17, 2024 · 2 comments

Comments

@pabloarosado
Copy link
Contributor

When creating a branch with a long name, the staging server is created with a trimmed version of that name.

For example, I created a branch called update-climate-data-and-fix-co2-concentration-issue, and the staging server is http://staging-site-update-climate-data-and-fix-co2-concentration-issu/.

Maybe it's good (or necessary) to avoid very long URLs. If that's the case, at least, the owidbot should account for this issue when displaying the URL of the server. In the case of the example, owidbot said:

Staging server:
Admin: http://staging-site-update-climate-data-and-fix-co2-concentration-issue/admin/login
Site: http://staging-site-update-climate-data-and-fix-co2-concentration-issue/
Login: ssh owid@staging-site-update-climate-data-and-fix-co2-concentration-issue

But those URLs do not exist.

@Marigold
Copy link
Collaborator

LXC containers have a hard limit on names to something like 63 characters, which is why we trim it. I'll fix the owidbot.

@Marigold
Copy link
Collaborator

Fixed by #2530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants