Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine new metadata fields #1920

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Combine new metadata fields #1920

merged 5 commits into from
Nov 8, 2023

Conversation

pabloarosado
Copy link
Contributor

  • Propagate description_key when doing variable operations.
  • Add tests.
  • Some small improvements on natural disasters metadata (some require the propagation of description_key to show up in charts).

@pabloarosado pabloarosado requested a review from Marigold November 7, 2023 15:26
@pabloarosado pabloarosado self-assigned this Nov 7, 2023
@pabloarosado pabloarosado marked this pull request as ready for review November 7, 2023 15:26
Marigold
Marigold approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@Marigold Marigold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pabloarosado pabloarosado merged commit 6a40d27 into master Nov 8, 2023
15 checks passed
@pabloarosado pabloarosado deleted the combine-new-metadata-fields branch November 8, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marigold Marigold Marigold approved these changes

Assignees

@pabloarosado pabloarosado

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pabloarosado @Marigold