Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Site Nav Updates #4513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

✨ Site Nav Updates #4513

wants to merge 1 commit into from

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Jan 31, 2025

Resolves #4414

Compare to Figma

Everything just manages to fit at the smallest md breakpoint 😮‍💨

site.nav.spacing.mp4

@ikesau ikesau requested a review from mlbrgl January 31, 2025 21:09
@owidbot
Copy link
Contributor

owidbot commented Jan 31, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-sitenav-updates

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-01-31 21:25:26 UTC
Execution time: 1.33 seconds

@mlbrgl
Copy link
Member

mlbrgl commented Feb 4, 2025

That's a tight fit, for sure! Maybe a bit too tight: from 960 to ~990, the donate button overflows into the margin (you can see it in your video; it's being pushed out as you get closer to 960).

Screenshot 2025-02-04 at 09 43 45

The search "bar" is also looking a bit crammed:

Screenshot 2025-02-04 at 09 45 28

Maybe we should only show the placeholder (and the bar) from "Search..." onwards?

Screenshot 2025-02-04 at 09 46 39

Copy link
Member

@mlbrgl mlbrgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cycle 2025.1: Site nav updates
3 participants