Windows .msi testing scenarios

[WIP]

• Documentation: https://github.com/owncloud/client/blob/msi-doc/doc/installing.rst#customizing-the-windows-installation

Some considerations:

Here are some notes and issues we stumbled upon during the exploratory sessions with @dschmidt.

Basic installation path

• The installer display default placeholder (e.g. [1]) values instead of the real paths, progress, etc. they should hold.

• Currently it seems the default "installation" option is not enough in some circumstances:
  • Difference between 32 and 64bit architectures: the shell extensions seem not to be fully installable - Does not matter if they are not selected from the installation wizard. => Selection should make a difference will investigate. This issue does only occur on Win 7 without updates tho, as checked with @michaelstingl we will document the issue but not fix it.
  • Registering the cloud provider integration: https://github.com/owncloud/client/pull/6113 needs additional write/change actions on the Windows Registry. (c.f. https://github.com/owncloud/client/pull/6113/files) => already fixed inside the client
  • Additional version no. referenced everywhere on the system - i.e. 2.5.0.0 instead of 2.5.0 => worse: proper version suffix is lost, like branch or git commit info

Upgrade path from NSIS

• We had to run the installer twice; first as "install" then as "change" to get the folders recreated (seems like the first run removed the old Program Files/ownCloud location and the next one was the one unpacking the installer contents).

Branding options

• We've noticed some discrepancies in terms of the shortcut naming (i.e. old "ownCloud testpilot edition" vs. new "testpilotcloud") => fixed.
• Icon quality seems rather pixelated, Domme thinks it has to do with the icon being taken from the .exe rather than the .ico itself. => was not the issue. Once https://github.com/owncloud/client/pull/6511 is merged, we can even have hires icons.
• Investigate the (double) size on disk of the branded client => cannot reproduce

Provisioning options and scenarios

Uninstalling the msi client

• User is still prompted with the "Reboot to get the Shell Extensions working" dialog when uninstalling the client
• Apparently, in some cases, the item from the start menu is not removed, causing multiple "missing DLL" errors on next OS startup (.exe is also preserved after running the uninstaller)
  • Also, the leftover .exe doesn't seem to be properly signed: