-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Get extended attributes for user for apps #40257
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
2b4895e
to
741c47c
Compare
This is a rebase of #36258 It needs someone to first decide if it is wanted, then review what it does and the technical code. |
If it is ready-go, yes. Otherwise I'd not spend time here at the moment. |
@jvillafanez @janackermann @JammingBen can someone review this. IMO it is ready - so if it looks OK on review then it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but we need to update all the "since" tags
I can do that... |
Get extended attributes for user from the apps. A new method which emits events to get the attributes for user, which is listened by apps to provide the attributes for the specific user. Use case for example: When apps are not whitelisted for guest user they should not be visible in the personal settings. Signed-off-by: Sujith H <[email protected]>
741c47c
to
a7ae9b5
Compare
done |
Kudos, SonarCloud Quality Gate passed! |
Note: changelog is added by PR #40277 - I forgot to add it here. |
@phil-davis Ooops. I cannot confirm your test results. |
Some guest app code was never merged - see comments in owncloud/guests#516 and PR owncloud/guests#518 |
Description
Get extended attributes for user from the apps. A
new method which emits events to get the attributes
for user, which is listened by apps to provide the
attributes for the specific user. Use case for example:
When apps are not whitelisted for guest user
they should not be visible in the personal settings.
Signed-off-by: Sujith H [email protected]
This is a rebase of #36258 - needs review and decision if it is wanted.
Related Issue
Motivation
Do not show the apps which are not whitelisted for the guest user.
How Has This Been Tested?
Types of changes
Checklist: