Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Get extended attributes for user for apps #40257

Merged
merged 5 commits into from
Aug 9, 2022

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Aug 1, 2022

Description

Get extended attributes for user from the apps. A
new method which emits events to get the attributes
for user, which is listened by apps to provide the
attributes for the specific user. Use case for example:
When apps are not whitelisted for guest user
they should not be visible in the personal settings.

Signed-off-by: Sujith H [email protected]

This is a rebase of #36258 - needs review and decision if it is wanted.

Related Issue

Motivation

Do not show the apps which are not whitelisted for the guest user.

How Has This Been Tested?

  • Enable customgroups. Make sure its not listed as whitelisted apps in guest configuration.
  • As guest user navigate to the settings page.
  • The settings page should not show customgroups. And it does not.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Aug 1, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@phil-davis phil-davis changed the title Get extended attributes for user for apps [full-ci] Get extended attributes for user for apps Aug 2, 2022
@owncloud owncloud deleted a comment from ownclouders Aug 2, 2022
@owncloud owncloud deleted a comment from ownclouders Aug 2, 2022
@owncloud owncloud deleted a comment from ownclouders Aug 2, 2022
@phil-davis phil-davis marked this pull request as ready for review August 2, 2022 07:50
@phil-davis
Copy link
Contributor Author

This is a rebase of #36258

It needs someone to first decide if it is wanted, then review what it does and the technical code.

@phil-davis
Copy link
Contributor Author

@pmaier1 is this something that is wanted? (see old PR #36258 for history/context)

@pmaier1
Copy link
Contributor

pmaier1 commented Aug 9, 2022

If it is ready-go, yes. Otherwise I'd not spend time here at the moment.

@phil-davis
Copy link
Contributor Author

@jvillafanez @janackermann @JammingBen can someone review this. IMO it is ready - so if it looks OK on review then it can be merged.
If you review and think it needs rework, then we can leave it for now.

Copy link
Member

@jvillafanez jvillafanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but we need to update all the "since" tags

@phil-davis
Copy link
Contributor Author

Looks good to me, but we need to update all the "since" tags

I can do that...

sharidas and others added 5 commits August 9, 2022 16:39
Get extended attributes for user from the apps. A
new method which emits events to get the attributes
for user, which is listened by apps to provide the
attributes for the specific user. Use case for example:
When apps are not whitelisted for guest user
they should not be visible in the personal settings.

Signed-off-by: Sujith H <[email protected]>
@phil-davis
Copy link
Contributor Author

Looks good to me, but we need to update all the "since" tags

I can do that...

done

@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

92.6% 92.6% Coverage
0.0% 0.0% Duplication

@phil-davis phil-davis merged commit 3e82a16 into master Aug 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the rebased-fix-personal-setting branch August 9, 2022 14:11
@phil-davis phil-davis mentioned this pull request Aug 9, 2022
11 tasks
@phil-davis
Copy link
Contributor Author

Note: changelog is added by PR #40277 - I forgot to add it here.

@jnweiger
Copy link
Contributor

jnweiger commented Sep 8, 2022

@phil-davis Ooops. I cannot confirm your test results.
For me, the guest user always has access to custom groups. whitelisted or not.
owncloud/guests#516

@phil-davis
Copy link
Contributor Author

Ooops. I cannot confirm your test results.

Some guest app code was never merged - see comments in owncloud/guests#516 and PR owncloud/guests#518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants