Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trashbin not saved when files_trashbin not whitelisted #525

Open
phil-davis opened this issue Sep 15, 2022 · 1 comment
Open

trashbin not saved when files_trashbin not whitelisted #525

phil-davis opened this issue Sep 15, 2022 · 1 comment

Comments

@phil-davis
Copy link
Contributor

  1. set the guests whitelist so that files_trashbin is not in the whitelist
  2. user Alice creates folder trashbin-test and shares it with full access with a new guest [email protected]
  3. user Alice creates file trashbin-test/file.txt
  4. Guest [email protected] logs in and browses into folder trashbin-test
  5. The guest deletes file.txt
  6. user Alice views the trashbin

file.txt is not in the trashbin of Alice.

a) The content that Alice entered in file.txt has been deleted by the guest user, but is not available in the trashbin of Alice. Alice has "lost" that content.

(a) seems to be "not a good thing" - Alice loses data, and may quite reasonably expect that her data will be available in the trashbin.

If Alice deletes the file herself, then it does get put in the trashbin. So Alice might be quite confused about why she completely lost her file when she shared with a guest.

@phil-davis
Copy link
Contributor Author

I think that the whitelist feature is intended to be used so that guests do not see some functionality. In this case (files_trashbin) the guest user should not see the trashbin (Deleted Files) on the classic webUI, and should not be able to use the API to query or restore from the trashbin.

But I think that when the guest deletes the file, the file should still be saved to the trashbin of Alice by the server - so that Alice (a real user) can have that available to her.

@pmaier1 what is the requirement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant