Fix binary lookup #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change to lookup binary at a specific path instead of searching the entire contents of each workspace Update to properly log all found LSP servers
nrayburn-tech
force-pushed
the
fix-binary-lookup
branch
from
f1e4266
to
6ef75c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be closer to how the VS Code plugin does it. Checks specifically for
${root}/node_modules/.bin/oxc_language_servernow (fallback includes the.exelookup for Windows). If you don't have a root workspace folder with the matching path, it will fail to find it.Depends on #58.