Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught exception in repeat #70

Open
minghuaw opened this issue May 29, 2024 · 1 comment
Open

Uncaught exception in repeat #70

minghuaw opened this issue May 29, 2024 · 1 comment
Assignees

Comments

@minghuaw
Copy link
Collaborator

While working on the macro version of the ops, the following test case was found to yield an exception that was not caught before crossing the ffi boundary

    #[test]
    fn test_repeat() {
        let stream = StreamOrDevice::default();

        // We are just testing that the macros compile
        let a = Array::from_int(5);
        let _a = repeat!(a, 3, 0);

        let a = Array::from_int(5);
        let _a = repeat!(a, 3, 0, stream = &stream);

        let a = Array::from_int(5);
        let _a = repeat!(a, 3, 0, dtype = f32);

        let a = Array::from_int(5);
        let _a = repeat!(a, 3, 0, dtype = f32, stream = &stream);
    }
@minghuaw minghuaw changed the title Uncaught error in repeat Uncaught exception in repeat May 29, 2024
@minghuaw minghuaw assigned minghuaw and dcvz and unassigned minghuaw May 29, 2024
@minghuaw
Copy link
Collaborator Author

Since we are moving to the new error handling approach. This should not be a problem anymore, but we should add a unit test for this just to be sure before closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants