Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users when brokers are down #199

Open
CKH4 opened this issue Jul 19, 2018 · 9 comments
Open

Warn users when brokers are down #199

CKH4 opened this issue Jul 19, 2018 · 9 comments

Comments

@CKH4
Copy link

CKH4 commented Jul 19, 2018

There should be a warning on the site when the brokers are not functioning. Ideally it would stop use of the site so that users don't think that it might still work.

@rfornea
Copy link
Contributor

rfornea commented Jul 19, 2018

Pasting this comment from the duplicate of this issue: perhaps the endpoint on the broker could check the status of the "DEPLOY_IN_PROGRESS" env variable. If that variable is either true or if the request to the broker totally fails, we could use the same screen on webinterface.

@CKH4
Copy link
Author

CKH4 commented Jul 19, 2018

That sounds like a logical way to go about it. If Taylor doesn't get to the design today I may be able to design something for it, depends on how much time I get.

@rfornea
Copy link
Contributor

rfornea commented Jul 19, 2018

I talked with Taylor about this. He's okay with us just designing something simple for this and we'll just replace it with his version when he finishes the other things he's working on.

@CKH4
Copy link
Author

CKH4 commented Jul 19, 2018

That sounds good. I assume you're taking the back end side of this, who is taking the front end?

@rfornea
Copy link
Contributor

rfornea commented Jul 19, 2018

For the backend, I'm a bit tied up with database stuff at the moment but I may be able to get to this later today, or perhaps @pzhao5 has some bandwidth.

For the front end @AaronVasquez do you have a preference on who does this, or mind if Connor takes it?

For the endpoint itself, how does everyone feel something like /api/v2/check-availability that will just return true or false?

@CKH4
Copy link
Author

CKH4 commented Jul 19, 2018

I don't have too much time at the moment so I probably can't do it but I'll keep tabs on the changes. That endpoint sounds good to me.

@rfornea
Copy link
Contributor

rfornea commented Jul 19, 2018

Changing the endpoint to /api/v2/status. It's more generic/reusable. At some point the webinterface may want to ask the broker for the status of other things as well before it starts an upload, so we may someday add additional parameters to the response. For now this is just going to come back like this:

{
    available:  true
}

or this:

{
    available:  false
}

@CKH4
Copy link
Author

CKH4 commented Jul 19, 2018

That sounds like a much better naming idea. I'm glad these ideas are being worked on now during the beta rather than later.

@rfornea
Copy link
Contributor

rfornea commented Sep 24, 2018

Taylor has designed a splash page for this. It's on Zeplin.

We could check the /status endpoint as soon as the user goes to oysterstorage and when the user clicks "Upload a File" we could take them to the splash page.

Another thing we could do is just grey out the "Upload a File" button so they can't click it in the first place, and if they manually try to go to the /upload-form page, we take them to the splash page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants